> On Oct. 10, 2016, 3:25 p.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.cpp, line 179 > > <https://reviews.apache.org/r/52208/diff/1/?file=1509029#file1509029line179> > > > > Why haven't you used `Duration::create()`? > > Joseph Wu wrote: > Didn't realize that existed :) > > That does look safer than plain-old casting. I will leave it up to you, > if you want to fix it.
I'll follow up with a patch. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52208/#review151986 ----------------------------------------------------------- On Sept. 23, 2016, 4:50 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52208/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2016, 4:50 a.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Fixed warnings in health_checker.cpp. > > > Diffs > ----- > > src/health-check/health_checker.cpp > 758cbb382b08743f518022ba66eaafbea7615592 > > Diff: https://reviews.apache.org/r/52208/diff/ > > > Testing > ------- > > Windows: buils > OSX: make check > > > Thanks, > > Daniel Pravat > >
