----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52704/#review152188 -----------------------------------------------------------
Fix it, then Ship it! src/linux/fs.cpp (line 141) <https://reviews.apache.org/r/52704/#comment221030> tailing `<<` should be in the next line ``` CHECK(xxx) << xxx << xxx ``` - Jie Yu On Oct. 10, 2016, 8:50 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52704/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 8:50 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6118 > https://issues.apache.org/jira/browse/MESOS-6118 > > > Repository: mesos > > > Description > ------- > > The original function now calls a helper which takes a string > representation of a 'MountInfoTable'. In a subsequent commit we will > use this helper to write more meaningful tests to stress the core > logic of the 'MountInfoTable::read()' functionality. > > > Diffs > ----- > > src/linux/fs.hpp 090c82616d965b1cedf9bb13ffcde2d37304a1f7 > src/linux/fs.cpp 4b10141a49dfb3c6defdb07e295eb14cfcdd36ce > > Diff: https://reviews.apache.org/r/52704/diff/ > > > Testing > ------- > > GTEST_FILTER="*Sorted*" src/mesos-tests > > > Thanks, > > Kevin Klues > >
