----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52703/#review152190 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/fs_tests.cpp (line 192) <https://reviews.apache.org/r/52703/#comment221045> I'd suggest we add more entries to this list to mimic a real mount table so that the assertions below are more meaningful src/tests/containerizer/fs_tests.cpp (line 198) <https://reviews.apache.org/r/52703/#comment221046> hashset? src/tests/containerizer/fs_tests.cpp (line 203) <https://reviews.apache.org/r/52703/#comment221047> if you use hashset, you can use ids.contains(xxx) which is more readable - Jie Yu On Oct. 10, 2016, 8:50 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52703/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 8:50 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6118 > https://issues.apache.org/jira/browse/MESOS-6118 > > > Repository: mesos > > > Description > ------- > > We allow entries in the MountInfoTable to be parent's of themselves. > This test makes sure that this functionality is exercised. > > > Diffs > ----- > > src/tests/containerizer/fs_tests.cpp > 0dd212f94d2845494163a86bc2059f999e018cd0 > > Diff: https://reviews.apache.org/r/52703/diff/ > > > Testing > ------- > > GTEST_FILTER="*Sorted*" src/mesos-tests > > > Thanks, > > Kevin Klues > >
