----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52738/#review152224 -----------------------------------------------------------
Patch looks great! Reviews applied: [52680, 52727, 52666, 52728, 52738] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 11, 2016, 2:24 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52738/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2016, 2:24 p.m.) > > > Review request for mesos, Benjamin Mahler and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > After image pull finished, use `inspectImage` to get > the returned image value. > > > Diffs > ----- > > src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e > > Diff: https://reviews.apache.org/r/52738/diff/ > > > Testing > ------- > > make > make check > > Also test with a real cases. > > 1) Remove busybox:latest > 2) Launch a task using busybox:latest , succeed. > 3) Check agent log, there are log messages of pull docker image. > ``` > I1011 16:28:14.538455 16307 docker.cpp:1014] Starting container > '0727d4b2-37ee-4aa6-8c15-7c3eac1fbdc7' for task 'test' (and executor 'test') > of framework 6f14d15e-4963-4984-bc55-91fe21b63560-0009 > I1011 16:28:14.539734 16307 docker.cpp:1470] Running docker -H > unix:///var/run/docker.sock inspect busybox:latest > I1011 16:28:14.649885 16304 docker.cpp:1544] Running docker -H > unix:///var/run/docker.sock pull busybox:latest > I1011 16:28:22.898789 16304 slave.cpp:5448] Querying resource estimator for > oversubscribable resources > I1011 16:28:22.899137 16304 slave.cpp:5462] Received oversubscribable > resources {} from the resource estimator > I1011 16:28:23.695930 16305 slave.cpp:4128] Received ping from > slave-observer(2)@192.168.56.12:5050 > I1011 16:28:30.308148 16306 docker.cpp:1470] Running docker -H > unix:///var/run/docker.sock inspect busybox:latest > I1011 16:28:30.416584 16302 docker.cpp:422] Docker pull busybox:latest > completed > I1011 16:28:30.418618 16302 docker.cpp:1322] Launching > 'mesos-docker-executor' with flags > '--container="mesos-6f14d15e-4963-4984-bc55-91fe21b63560-S1.0727d4b2-37ee-4aa6-8c15-7c3eac1fbdc7" > --docker="docker" --docker_socket="/var/run/docker.sock" --help="false" > --initialize_driver_logging="true" > --launcher_dir="/root/src/mesos/m1/mesos/build/src" --logbufsecs="0" > --logging_level="INFO" --mapped_directory="/mnt/mesos/sandbox" > --quiet="false" > --sandbox_directory="/tmp/mesos/slaves/6f14d15e-4963-4984-bc55-91fe21b63560-S1/frameworks/6f14d15e-4963-4984-bc55-91fe21b63560-0009/executors/test/runs/0727d4b2-37ee-4aa6-8c15-7c3eac1fbdc7" > --stop_timeout="0ns"' > ``` > > > Thanks, > > Guangya Liu > >
