----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52764/#review152254 -----------------------------------------------------------
Fix it, then Ship it! I can fix this before committing. docs/upgrades.md (line 56) <https://reviews.apache.org/r/52764/#comment221155> I'd prefer: `Container Logger *recovery* method` docs/upgrades.md (line 209) <https://reviews.apache.org/r/52764/#comment221156> Rewording: Mesos 1.1 removes the `ContainerLogger`'s `recover()` method. The `ContainerLogger` had an incomplete interface for a stateful implementation. This removes the incomplete parts to avoid adding tech debt in the containerizer. Please see [MESOS-6371](https://issues.apache.org/jira/browse/MESOS-6371) for more information. - Joseph Wu On Oct. 11, 2016, 5:09 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52764/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2016, 5:09 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-6371 > https://issues.apache.org/jira/browse/MESOS-6371 > > > Repository: mesos > > > Description > ------- > > Updated upgrades.md for removing 'recover()' in container logger. > > > Diffs > ----- > > docs/upgrades.md babadf74a594b037988710151c89673a64446f85 > > Diff: https://reviews.apache.org/r/52764/diff/ > > > Testing > ------- > > N/A. > > > Thanks, > > Gilbert Song > >
