----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52767/#review152256 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On Oct. 12, 2016, 1:58 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52767/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 1:58 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Used `CHECK(contains(name))` in `DRFSorter::activate`. > > > Diffs > ----- > > src/master/allocator/sorter/drf/sorter.cpp > 790c9320f0c539b330e4fd1a9b608319f51992de > > Diff: https://reviews.apache.org/r/52767/diff/ > > > Testing > ------- > > make > make check > > ``` > [==========] Running 11 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 11 tests from SorterTest > [ RUN ] SorterTest.DRFSorter > [ OK ] SorterTest.DRFSorter (5 ms) > [ RUN ] SorterTest.WDRFSorter > [ OK ] SorterTest.WDRFSorter (1 ms) > [ RUN ] SorterTest.WDRFSorterUpdateWeight > [ OK ] SorterTest.WDRFSorterUpdateWeight (0 ms) > [ RUN ] SorterTest.SplitResourceShares > [ OK ] SorterTest.SplitResourceShares (1 ms) > [ RUN ] SorterTest.UpdateAllocation > [ OK ] SorterTest.UpdateAllocation (1 ms) > [ RUN ] SorterTest.MultipleSlaves > [ OK ] SorterTest.MultipleSlaves (1 ms) > [ RUN ] SorterTest.MultipleSlavesUpdateAllocation > [ OK ] SorterTest.MultipleSlavesUpdateAllocation (0 ms) > [ RUN ] SorterTest.UpdateTotal > [ OK ] SorterTest.UpdateTotal (1 ms) > [ RUN ] SorterTest.MultipleSlavesUpdateTotal > [ OK ] SorterTest.MultipleSlavesUpdateTotal (0 ms) > [ RUN ] SorterTest.RevocableResources > [ OK ] SorterTest.RevocableResources (0 ms) > [ RUN ] SorterTest.SharedResources > [ OK ] SorterTest.SharedResources (2 ms) > [----------] 11 tests from SorterTest (12 ms total) > > [----------] Global test environment tear-down > [==========] 11 tests from 1 test case ran. (30 ms total) > [ PASSED ] 11 tests. > ``` > > > Thanks, > > Guangya Liu > >
