> On Oct. 10, 2016, 3:28 p.m., Till Toenshoff wrote: > > configure.ac, lines 616-617 > > <https://reviews.apache.org/r/51716/diff/3/?file=1517706#file1517706line616> > > > > Not a biggy but maybe it is a good idea to make this better readable / > > parseable by creating a local temporary variable. > > Benjamin Bannier wrote: > I agree, this is not very readible. I tried to make this more readible, > but did not succeed with my limited autoconf/m4 knowledge, so I added a > comment explaining what exactly we do here, and a `TODO`, > > +# We here set up `TEST_DRIVER` to contain an unexpanded automake > +# variable name; this allows us to reuse the test runner to run > bundled > +# 3rdparty checks. The special quoting ensures that this containing a > +# space is not expanded by autoconf. > +# TODO(bbannier): Make this more readible by using autoconf/m4 magic. > > Do you think this is sufficient?
Perfectly fine, thanks for trying :) - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51716/#review151988 ----------------------------------------------------------- On Oct. 11, 2016, 8:19 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51716/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2016, 8:19 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-6140 > https://issues.apache.org/jira/browse/MESOS-6140 > > > Repository: mesos > > > Description > ------- > > Added configure option for Mesos test runner. > > > Diffs > ----- > > configure.ac 034bb91bfacd74ce0349685f1760f9784fdc1a18 > > Diff: https://reviews.apache.org/r/51716/diff/ > > > Testing > ------- > > `make check` with `--enable-parallel-test-execution` (OS X, python 2.7.12) > > > Thanks, > > Benjamin Bannier > >