-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52779/
-----------------------------------------------------------
Review request for mesos, Daniel Pravat and Joseph Wu.
Repository: mesos
Description
-------
Reimplement test macros without (non-standard) compound statements.
In GCC, compound statements that are wrapped in parentheses are treated
as expresssions. For example, `({int x = 3; x;})` would return 3. This
is useful, for example, in macros, when you don't want to explicitly
define a function that returns a value.
Unfortunately, this is non-standard, and not supported at all by MSVC.
Since our tests depend heavily on this construct, we must re-write all
of them from scratch before we can light them up on Windows.
This commit will port the subset of testing constructs that use this
feature, which we need in order to add Windows support for the tests we
care about.
Diffs
-----
src/tests/api_tests.cpp f0bafd1d5207a687ca0489b05ed1acdc2a6d875d
src/tests/authentication_tests.cpp fc7afae0abde8e9274685b9a2121f5a91d59f3d6
src/tests/command_executor_tests.cpp 6e47243941626bb5b6224430f9a12ced8a3f5062
src/tests/container_logger_tests.cpp f76117230e0517ddc3cb8e0bf482085fad6950d2
src/tests/containerizer/cgroups_isolator_tests.cpp
b5797574ca2bfe3a005c80a3ba6bb6965c54cc95
src/tests/containerizer/cni_isolator_tests.cpp
b032c4345683813bca5f9a5eec09f73d860299cc
src/tests/containerizer/cpu_isolator_tests.cpp
b16cde3c3ddb47859aec2d0496df4970def7c89f
src/tests/containerizer/docker_containerizer_tests.cpp
6d26797abf6d2b5e42b9e7743789e1edc62c9c1a
src/tests/containerizer/docker_volume_isolator_tests.cpp
ca7bffd3b1773a11a4679d114885d3edd977b02b
src/tests/containerizer/linux_capabilities_isolator_tests.cpp
f040c209b4b4c87cef00b0569b7da7581f4ccf03
src/tests/containerizer/linux_filesystem_isolator_tests.cpp
eb191a32381f9d1ca84ec29adf352dde375c2f2d
src/tests/containerizer/memory_isolator_tests.cpp
62cffa748b1d18d28ad1118f2b26c1caac3f623a
src/tests/containerizer/memory_pressure_tests.cpp
42ae3232a5e0c508382ba3be97c4ee9787151236
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp
fea1f9f0a03373692ef2a6dd2bc5722dc6f46d5b
src/tests/containerizer/port_mapping_tests.cpp
fbdc0db9238c85d2f6eaba7d13ee5ce23342b527
src/tests/containerizer/provisioner_appc_tests.cpp
a999fc7991da805dfbcdf5659fcfb762aee5b2b9
src/tests/containerizer/provisioner_docker_tests.cpp
10fbc4149ac2e7503ffe7f2746fbd0e14a2365b4
src/tests/containerizer/runtime_isolator_tests.cpp
c0c11607024b6a80d5bf5a486b91f7905a9083d7
src/tests/containerizer/xfs_quota_tests.cpp
27d1f9f64ba3000154ccbe3e9734be33fe7f32c0
src/tests/credentials_tests.cpp 1ceb31b72446a87771705cab2255c264d8e00c08
src/tests/default_executor_tests.cpp 9e0fd678a7f5e9c2288fbb11a60cf6f339efa24f
src/tests/disk_quota_tests.cpp 90c42b301d749e7a9c6d6d42a51e929ec66d761c
src/tests/dynamic_weights_tests.cpp 6f1e249e51e41aee7fdb22a2ccbfa9be71774e6d
src/tests/exception_tests.cpp 7b66bd1b0beb004641fe0a08e02db168f2653354
src/tests/executor_http_api_tests.cpp
a9f1a7b0498acd541c6f58ad1388da49c9951e22
src/tests/fault_tolerance_tests.cpp 5a9944cf459ab688907d95bbda09f464b37efd1e
src/tests/fetcher_cache_tests.cpp 03e817d46194d451eceb70f4cebb54dfdcb4c2e7
src/tests/files_tests.cpp f6a6aeaa4efa05957d1038c564157216fce70246
src/tests/gc_tests.cpp d9776b602bee780b9732cd93d06b9c8f3cc8a4d0
src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522
src/tests/hook_tests.cpp d334d6c5ff7f966d55b395bfbf4f000025ee3fa2
src/tests/http_fault_tolerance_tests.cpp
57ef562058f8abf9256e2ab8a4a85b36b5a7add4
src/tests/logging_tests.cpp 886dcd0d6d6ccf509c98578e8b86b1c6ecd5775f
src/tests/master_allocator_tests.cpp bb94e38d5bb472801366c172cfc036f2eecdcbcb
src/tests/master_authorization_tests.cpp
a4623d15c246651fd1038fdedf16321b1d5f273f
src/tests/master_contender_detector_tests.cpp
2a7d713f74c907235f82d83eaf46630046645faf
src/tests/master_maintenance_tests.cpp
77eb405ab7314da906bed9ec1d0018c24928d8d8
src/tests/master_quota_tests.cpp 48be7406181646c8cc1d169b82a4a4ca71cdf03b
src/tests/master_slave_reconciliation_tests.cpp
2983c1b074c2d4179e95e619083f5dd4e9ac6730
src/tests/master_tests.cpp 88cf1e612ad8186ef2cea161b3a52b0df9517305
src/tests/master_validation_tests.cpp
99e350e0587e73e9ee25ef20dd369cd146bd446a
src/tests/mesos.hpp 5e15f5164cddebd60bb6d9856ae63ad357643cb2
src/tests/mesos.cpp 2aae160fb941ab3672a5665ae27f517ff40600e2
src/tests/metrics_tests.cpp 27fc35f3bc47fc2905f4ce400b1051307dcacb2e
src/tests/oversubscription_tests.cpp b356fb62a4e068bc171a75a76001c6d0e76af92a
src/tests/partition_tests.cpp 12fe8593ff17c35d540f944c428cf7f33b7dcbb3
src/tests/persistent_volume_endpoints_tests.cpp
f35592ae311f499999d3e331fa78c8e427f34bf5
src/tests/persistent_volume_tests.cpp
e10a79e9662530e143ccaa2aa2506a4d25158364
src/tests/rate_limiting_tests.cpp 61674155bebea493ec60b277b72fdcf8f366e26b
src/tests/reconciliation_tests.cpp 1412090299df388456f04ed58a1d384ce3ff550a
src/tests/registrar_tests.cpp 0433b26f47d25e819533706fe1adbe210b5b6bcf
src/tests/registrar_zookeeper_tests.cpp
598a93059b062438f0bebb5273e6965604db39fc
src/tests/reservation_endpoints_tests.cpp
7d271085d822e85d27cea5361bfee0d0d91a5691
src/tests/reservation_tests.cpp 6c28ab4557f342134efce0ad7cb174a5adb4dc10
src/tests/resource_offers_tests.cpp 3dde7bf236cb88d72dce73da18d3bc55f0f9402f
src/tests/role_tests.cpp 47fe0f06fb7728694445a62ccfe818fd9bf37c2c
src/tests/scheduler_driver_tests.cpp faf2e6c8ad17e07964b4340d0b340654b03f9086
src/tests/scheduler_event_call_tests.cpp
8ea5eb802b194fc149994560cfc8a6212d351087
src/tests/scheduler_http_api_tests.cpp
80a2ef0af9a4c67deaef40e1f36343868ee4428f
src/tests/scheduler_tests.cpp b0ea0bbcce9d847285fda40f778caaf721804457
src/tests/script.cpp ef6b22aaeb056ed489f2c519e1a02644f2653329
src/tests/slave_authorization_tests.cpp
6bd2aa96cb05aa087c0807cc3dd1830451efe106
src/tests/slave_recovery_tests.cpp 703948f7a6861a4401ee45ce9cae2644106083f3
src/tests/slave_tests.cpp bb6216f3f608ce8620a3a11ca716389a906f2d26
src/tests/status_update_manager_tests.cpp
38d8913a5b33aa5325d0bc632c0a1d80480eddf8
src/tests/teardown_tests.cpp 0babf8c99f133c3f0dada772bd5cd2601c47a080
Diff: https://reviews.apache.org/r/52779/diff/
Testing
-------
Thanks,
Alex Clemmer
