-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52707/#review152321
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Oct. 10, 2016, 9:42 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52707/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 9:42 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Kevin Klues, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A locally installed virtualenv does not always show up on the `PATH`,
> which fails `which virtualenv`.  This adds an extra search location
> based on the user's site package install directory.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/bootstrap 74a8568daef4e0cb93911352cc73c165a2fbea1d 
> 
> Diff: https://reviews.apache.org/r/52707/diff/
> 
> 
> Testing
> -------
> 
> pip uninstall virtualenv -y  # Global
> pip uninstall virtualenv -y  # Local
> 
> src/cli_new/bootstrap        # Fails
> 
> pip install --user virtualenv
> 
> src/cli_new/bootstrap        # Succeeds
> 
> pip uninstall virtualenv -y  # Local
> pip install virtualenv       # Global
> 
> src/cli_new/bootstrap        # Succeeds
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to