-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52288/#review152329
-----------------------------------------------------------




src/tests/persistent_volume_tests.cpp (lines 1031 - 1033)
<https://reviews.apache.org/r/52288/#comment221316>

    The wait on `framework1` seem to be unncessary. We don't use `framework1` 
and we wait on offers anyway.



src/tests/persistent_volume_tests.cpp (lines 1060 - 1063)
<https://reviews.apache.org/r/52288/#comment221344>

    The reason given here is pretty high-level (basically the purpose of this 
test). How about narrowing it down a bit? 
    
    ```
    It's not important whether the volume is used (the task is killed soon and 
its purpose is only for splitting the offer).
    ```



src/tests/persistent_volume_tests.cpp (lines 1096 - 1098)
<https://reviews.apache.org/r/52288/#comment221317>

    The wait on `framework2` seem to be unncessary. We don't use `framework2` 
and we wait on offers anyway.



src/tests/persistent_volume_tests.cpp (line 1109)
<https://reviews.apache.org/r/52288/#comment221319>

    Kill this given the comment on settling the clock before registering 
framework2.


- Jiang Yan Xu


On Oct. 7, 2016, 8:12 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52288/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2016, 8:12 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6257
>     https://issues.apache.org/jira/browse/MESOS-6257
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When a framework issues a DESTROY of a shared volume, and that volume
> is not in use by a running or a pending task, we rescind the offers
> from frameworks to which the shared volume is present in pending offers
> so that the volume is not assigned to any task in a future ACCEPT call.
> At that time, we need to recover the resources as well for proper
> accounting of such resources by the allocator.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp c7e74df71aa31edb490f4f3bd95f2d5aa94b4324 
>   src/tests/persistent_volume_tests.cpp 
> e10a79e9662530e143ccaa2aa2506a4d25158364 
> 
> Diff: https://reviews.apache.org/r/52288/diff/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Reply via email to