----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52412/#review152406 -----------------------------------------------------------
Ship it! Ship It! - Joseph Wu On Oct. 12, 2016, 2:06 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52412/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 2:06 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-6290 > https://issues.apache.org/jira/browse/MESOS-6290 > > > Repository: mesos > > > Description > ------- > > Currently, there is an issue in mesos containerizer using logger > for nested contaienrs: > > An empty executorinfo is passed to logger when launching a nested > container, it would potentially break some logger modules if any > module tries to access the required proto field (e.g., executorId). > > We should pass the ExecutorInfo of a nested container's top level > parent container to the logger when launching a nested container. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 7ec6f78c739145c874fb5ee63c5034dfb838c17c > > Diff: https://reviews.apache.org/r/52412/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >