-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52787/#review152455
-----------------------------------------------------------
I should have looked at this more carefully before giving it a Ship it. It
seemed reasonable at first glance though.
Did you attempt to compile it before posting the patch? Looks like there were
errors with the flags definition.
```
In file included from ../../src/local/main.cpp:26:0:
../../src/local/flags.hpp: In constructor
'mesos::internal::local::Flags::Flags()':
../../src/local/flags.hpp:54:10: error: 'runtime_dir' is not a member of
'mesos::internal::local::Flags'
add(&Flags::runtime_dir,
```
- Kevin Klues
On Oct. 12, 2016, 4:13 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52787/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2016, 4:13 p.m.)
>
>
> Review request for mesos, Jie Yu and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set `runtime_dir` to a temporary folder in `mesos-local`.
>
>
> Diffs
> -----
>
> bin/mesos-local-flags.sh.in 5b4553a808dc9f34a15390e69b2f85e95761ec53
> src/local/flags.hpp c77eff13e7a63630ff6c9428e57f3f6707e1f30f
>
> Diff: https://reviews.apache.org/r/52787/diff/
>
>
> Testing
> -------
>
> To void this error when launch `mesos-local` without `sudo`
>
> ```
> message: 'Failed to launch container: Failed to make the containerizer
> runtime directory
> '/var/run/mesos/containers/f2d6947f-2916-4f1a-90dc-3d137b360b9c': Permission
> denied; Abnormal executor termination: unknown container'
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
