-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50674/#review152610
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/gtest.hpp (line 179)
<https://reviews.apache.org/r/50674/#comment221690>

    Add a TODO to remove these once we've implemented/fixed the tests.



3rdparty/stout/tests/os_tests.cpp (lines 129 - 131)
<https://reviews.apache.org/r/50674/#comment221689>

    What about defining a macro:
    ```
    #ifndef __WINDOWS__
      #define SLEEP_COMMAND(x) "sleep x"
    #else
      #define SLEEP_COMMAND(x) "timeout x"
    #endif // __WINDOWS__  
    ```
    
    We shell out to `sleep` in lots of tests, so this might come in handy later.


- Joseph Wu


On Oct. 11, 2016, 4:49 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50674/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2016, 4:49 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A large number of Stout test files are currently not being built on
> Windows.  Many of these files contain tests for parts of Stout that have
> already been ported, or require only trivial fixes to work (such as
> removing `#include`s on Windows). A small minority of the tests contain
> bugs that we should fix.
> 
> This commit will add these files to the build, fix some of the
> trivially-fixable tests, and disable tests that are known to fail
> because of bugs, including comments explaining why and links to JIRA
> issues where appropriate.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/gtest.hpp 
> fca304a0be6ccfdabb351d43ee670435978c1f0f 
>   3rdparty/stout/include/stout/mac.hpp 
> 91c4fdad350459b3e0bdf1744089e14ac883829a 
>   3rdparty/stout/tests/CMakeLists.txt 
> 49971c7ccff319c96ed1f48cb2c9665695090688 
>   3rdparty/stout/tests/flags_tests.cpp 
> 94ba915c40836e476cf6097274a85c55acd4d73b 
>   3rdparty/stout/tests/ip_tests.cpp 59e69a51e41b4773cb7c5a5de9f70d4810fd0294 
>   3rdparty/stout/tests/mac_tests.cpp ebd50a00585ef37ea2fa244d48bdd90036040258 
>   3rdparty/stout/tests/os/rmdir_tests.cpp 
> ffe234baac305e26b5a29cffcdd310350d10167e 
>   3rdparty/stout/tests/os_tests.cpp 6a7b836f7102d9e014eaf9dbd47e33b987becb33 
> 
> Diff: https://reviews.apache.org/r/50674/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Reply via email to