-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52847/#review152626
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Oct. 13, 2016, 11:25 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52847/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2016, 11:25 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Kevin Klues, and Timothy 
> Chen.
> 
> 
> Bugs: MESOS-6173
>     https://issues.apache.org/jira/browse/MESOS-6173
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, the protobuf definition for docker v2 image manifest
> is not correct. Some proto fields should not be 'required'. E.g.,
> when using the private docker registry from JFrog, the 'kid' (the
> key ID) may not exist in the JWK from the manifest signature.
> 
> Depending on this reference:
> https://tools.ietf.org/html/rfc7517#section-4.5
> 
> 'kid' should be OPTIONAL.
> 
> This patch re-inspects the specification of JWS and JWK, and
> fixed the wrong defined protobuf fields.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/v2.proto e2c0a131b8429ca086bc5cd09dccfe3e8d2e50ac 
> 
> Diff: https://reviews.apache.org/r/52847/diff/
> 
> 
> Testing
> -------
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to