-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52386/#review152844
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Oct. 6, 2016, 2:58 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52386/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2016, 2:58 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3335
>     https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Here we explicitly disable rvalue constructors and assignment
> operators for `flags::FlagsBase` since we plan for this class to be
> used in virtual inheritance scenarios.  Here e.g., constructing from
> an rvalue will be problematic since we can potentially have multiple
> lineages leading to the same base class, and could then potentially
> use a moved from base object.
> 
> These functions would be implicitly generated only for C++14, but in
> C++11 only the versions taking lvalue references should be. GCC seems
> to create all of these even in C++11 mode so we need to explicitly
> disable them.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/flags/flags.hpp 
> eab8a001ed19755de58386a55ed4972f58026b29 
> 
> Diff: https://reviews.apache.org/r/52386/diff/
> 
> 
> Testing
> -------
> 
> Tested as part of the review chain ending in 
> https://reviews.apache.org/r/52388/ on various Linux configurations in 
> internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to