-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46823/#review152879
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Oct. 6, 2016, 2:59 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46823/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2016, 2:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Michael Park.
> 
> 
> Bugs: MESOS-3335
>     https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> While right now we can technically `add` variables to `Flags` classes
> which are not members, the in order to have correct copy semantics for
> `Flags` only member variables should be used.
> 
> Here we changed all instances to a full pointer-to-member syntax in
> the current code.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> c8350cf8e512dca23933725e6edb3e3d94380211 
> 
> Diff: https://reviews.apache.org/r/46823/diff/
> 
> 
> Testing
> -------
> 
> Tested as part of the review chain ending in 
> https://reviews.apache.org/r/52388/ on various Linux configurations in 
> internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to