----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/#review152882 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On Oct. 6, 2016, 2:59 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46825/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 2:59 p.m.) > > > Review request for mesos, Alexander Rukletsov and Michael Park. > > > Bugs: MESOS-3335 > https://issues.apache.org/jira/browse/MESOS-3335 > > > Repository: mesos > > > Description > ------- > > Fully-typed all FlagsBase::add overloads. > > > Diffs > ----- > > 3rdparty/stout/include/stout/flags/flags.hpp > eab8a001ed19755de58386a55ed4972f58026b29 > > Diff: https://reviews.apache.org/r/46825/diff/ > > > Testing > ------- > > Tested as part of the review chain ending in > https://reviews.apache.org/r/52388/ on various Linux configurations in > internal CI. > > > Thanks, > > Benjamin Bannier > >