> On Oct. 17, 2016, 5:52 p.m., haosdent huang wrote: > > src/launcher/default_executor.cpp, line 1034 > > <https://reviews.apache.org/r/52879/diff/1/?file=1538032#file1538032line1034> > > > > Let's use `agent_pid` here? Since we rename slave to agent. > > haosdent huang wrote: > hmm, I saw we still use `slave_pid` in the default-executor. Would be > better to keep consistency with there. Let me drop this.
Just realize we use `MESOS_SLAVE_PID` for quite a long time before staring rename `slave` to `agent`, sorry for create incorrect issue before. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/#review152909 ----------------------------------------------------------- On Oct. 14, 2016, 5:17 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52879/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2016, 5:17 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, Jie Yu, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Updated the command and the default executor so that they use only > `stout::flags` to load config options. > > They used to use a mix of `stout::flags` and `os::getenv`. > > > Diffs > ----- > > src/launcher/default_executor.cpp af4a97f7de5f2157aa65fdab742455b0683c40a4 > src/launcher/executor.cpp 3e95d6029bea0ce6e0dfb39c24b795fe98d90d13 > > Diff: https://reviews.apache.org/r/52879/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Gastón Kleiman > >
