> On Oct. 17, 2016, 11:22 a.m., Neil Conway wrote:
> > The mode of a volume doesn't necessarily have anything to do with whether 
> > the volume is shared -- perhaps it would be better to document this in the 
> > persistent-volume doc page, and link to it from here?

It makes sense to have a section in persistent-volumes.md to describe the 
general case for launching tasks with the volumes (e.g., you can actually 
change `container_path` when using it)

I am thinking of doing some improvements on persistent volumes (MESOS-6374) 
that may change that section (if we write one) and figured we can update it 
afterwards.

Here in this doc I mostly wanted to talk about from the user's perspective why 
and when you would want to use shared read-only persistent volumes (which 
doesn't make sense to regular persistent volumes) so I think this paragraph is 
going to stay even when the general persistent-volumes.md has a section for 
"using persisent volumes in LAUNCH". 

I can see that we remove the example and link to persistent-volumes.md later 
though but perhaps let's add it here for now and remove it later when that's 
done?


> On Oct. 17, 2016, 11:22 a.m., Neil Conway wrote:
> > docs/shared-resources.md, line 168
> > <https://reviews.apache.org/r/52934/diff/1/?file=1539702#file1539702line168>
> >
> >     I think we should discuss what happens if you try to write to a 
> > read-only volume.

SG.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52934/#review152923
-----------------------------------------------------------


On Oct. 17, 2016, 11:15 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52934/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 11:15 a.m.)
> 
> 
> Review request for mesos, (Disabled_DoNotUse) Anindya Sinha and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Explain read-only mode of persistent volumes in shared-resources.md.
> 
> 
> Diffs
> -----
> 
>   docs/shared-resources.md 29e43389c530f816118a32dcd7c2f1b82b0af431 
> 
> Diff: https://reviews.apache.org/r/52934/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to