----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52083/#review152997 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Oct. 13, 2016, 2:10 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52083/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 2:10 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6206 > https://issues.apache.org/jira/browse/MESOS-6206 > > > Repository: mesos > > > Description > ------- > > Previously, explicit reconciliation for an agent that was in the process > of reregistering or unregistering returned no results. This degree of > cleverness seems unwarranted: if the agent hasn't completed the > reregistration or unregistration process, it seems simpler for the > master to return the previous state of the agent. This is what the > framework would observe if their reconcile request lost the race with > the reregister/unregister operation, anyway. > > Note that since reregistering agents are no longer considered to be "in > transition", we need to slightly adjust the rules for how we update the > `slaves.recovered` collection in the master: an agent remains in the > "recovered" collection until it has been marked reachable in the > registry (rather than removing it from "recovered" as soon as the > reregistration process beings). This is more consistent with how we > manage the other collections in the master anyway: an agent appears in > the `recovered` list until the registry operation that reregisters it > has been successfully applied. > > > Diffs > ----- > > src/master/master.hpp 43518b9bf1bfaa54e26acc7f2e70c4161c667a84 > src/master/master.cpp 7ef898781ce5c2349ffeaa3ce43e68dede19c852 > src/tests/master_tests.cpp 88cf1e612ad8186ef2cea161b3a52b0df9517305 > src/tests/reconciliation_tests.cpp 1412090299df388456f04ed58a1d384ce3ff550a > > Diff: https://reviews.apache.org/r/52083/diff/ > > > Testing > ------- > > `make check` on OSX, Linux. > > > Thanks, > > Neil Conway > >
