-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52659/#review152999
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/master_authorization_tests.cpp (line 743)
<https://reviews.apache.org/r/52659/#comment222203>

    TASK_DROPPED



src/tests/master_authorization_tests.cpp (line 781)
<https://reviews.apache.org/r/52659/#comment222207>

    This test looks identical to SlaveRemoved test. Please kill this in a 
different review.


- Vinod Kone


On Oct. 7, 2016, 11:52 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52659/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2016, 11:52 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6329
>     https://issues.apache.org/jira/browse/MESOS-6329
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When a task launch fails due to a transient error (e.g., insufficient
> available resources at an agent), the master sends a TASK_LOST update to
> the framework. For PARTITION_AWARE frameworks, we now send TASK_DROPPED
> instead.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 8837f3d55be99626f79ed7f88eee021f115a2889 
>   src/tests/master_authorization_tests.cpp 
> a4623d15c246651fd1038fdedf16321b1d5f273f 
>   src/tests/master_tests.cpp 88cf1e612ad8186ef2cea161b3a52b0df9517305 
> 
> Diff: https://reviews.apache.org/r/52659/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to