-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51008/#review153003
-----------------------------------------------------------




src/cli_new/bin/tests.py (lines 23 - 25)
<https://reviews.apache.org/r/51008/#comment222212>

    This actually failed to lint after applying:
    ```
    Checking 1 Python file
    ************* Module tests
    E: 23, 0: Unable to import 'colour_runner.runner' (import-error)
    E: 25, 0: Unable to import 'termcolor' (import-error)
    Total errors found: 2
    ```
    
    Reason being that I had a pre-existing virtualenv, which did not have these 
modules installed.
    
    Doing `rm -rf src/cli_new/.virtualenv/` allows the linter to pass.


- Joseph Wu


On Oct. 17, 2016, 1:11 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51008/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 1:11 p.m.)
> 
> 
> Review request for mesos, Haris Choudhary and Joseph Wu.
> 
> 
> Bugs: MESOS-6032
>     https://issues.apache.org/jira/browse/MESOS-6032
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added infrastructure for unit tests in the new python-based CLI.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/bin/mesos-cli-tests PRE-CREATION 
>   src/cli_new/bin/tests.py PRE-CREATION 
>   src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d40000318f2d0e439a6edf 
> 
> Diff: https://reviews.apache.org/r/51008/diff/
> 
> 
> Testing
> -------
> 
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
> 
> (mesos-cli) $ mesos-cli-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Reply via email to