> On Oct. 18, 2016, 12:02 a.m., Jie Yu wrote: > > src/tests/containerizer/linux_capabilities_isolator_tests.cpp, line 100 > > <https://reviews.apache.org/r/52682/diff/1/?file=1529586#file1529586line100> > > > > const UsaImage&
I believe we always pass fundamental types like this enum by value. This one here is almost certainly not bigger than a pointer. Can we just drop this, or would you like me to collect a list of examples in the code base? > On Oct. 18, 2016, 12:02 a.m., Jie Yu wrote: > > src/tests/containerizer/linux_capabilities_isolator_tests.cpp, line 101 > > <https://reviews.apache.org/r/52682/diff/1/?file=1529586#file1529586line101> > > > > const Result& Dito. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52682/#review152968 ----------------------------------------------------------- On Oct. 18, 2016, 8:59 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52682/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 8:59 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > We remove an unused using declaration, and replace several bool > parameters with more readable enum values. > > > Diffs > ----- > > src/tests/containerizer/linux_capabilities_isolator_tests.cpp > edb46659324c4c6345606cfa4c19f4fce05c59fe > > Diff: https://reviews.apache.org/r/52682/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
