> On Oct. 17, 2016, 6 p.m., Joseph Wu wrote: > > src/cli_new/pylint.config, line 13 > > <https://reviews.apache.org/r/52939/diff/1/?file=1539773#file1539773line13> > > > > I see a single 2 character variable name `io` here: > > https://reviews.apache.org/r/52953/diff/1#0 -- Line 306 > > I think a longer variable name is reasonable there. > > > > `ip` can be added to the `good-names`. > > Kevin Klues wrote: > I didn't add this just to remove the warning (though that's what > triggered it). I added it because I figured allowing 2 character variable > names was probably a good thing in general. > > Are you suggesting that we drop the patch in favor of disallowing 2 > character variable names in general?
Yeah, I'm in favor of keeping the warning. We prefer longer/descriptive names in C++ and I'd say the same thing applies here. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52939/#review153007 ----------------------------------------------------------- On Oct. 17, 2016, 1:11 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52939/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2016, 1:11 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5676 > https://issues.apache.org/jira/browse/MESOS-5676 > > > Repository: mesos > > > Description > ------- > > Updated CLI pylint configuration to allow 2 character variable names. > > > Diffs > ----- > > src/cli_new/pylint.config c398220db063d249e6c62cf7e8cd6757e7860630 > > Diff: https://reviews.apache.org/r/52939/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
