> On Oct. 17, 2016, 6 p.m., Joseph Wu wrote: > > src/cli_new/pylint.config, line 15 > > <https://reviews.apache.org/r/52941/diff/1/?file=1539775#file1539775line15> > > > > Is this used anywhere? I did not encounter a linting error for this in > > your chain. > > Kevin Klues wrote: > I know I encountered it at some point, but maybe refactoring removed it. > Anyway, again, I personally think this seems like a reasonable one to > disable, but I guess I can discard it until it comes up again. > > In general I haven't been actively searching for a list of warnings to > disable, but when one crops up and it seems reasonable to disable globally, > that's when I've been adding these in there. Seems we may disagree on what > should be disabled globally though... > > Should I drop this one too?
This one is reasonable to disable. I'd say that `struct`-like classes are more easily documented than things like named-tuples or plain old dictionaries. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52941/#review153008 ----------------------------------------------------------- On Oct. 17, 2016, 1:11 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52941/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2016, 1:11 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5676 > https://issues.apache.org/jira/browse/MESOS-5676 > > > Repository: mesos > > > Description > ------- > > Updated CLI pylint configuration to allow 0 public methods. > > > Diffs > ----- > > src/cli_new/pylint.config c398220db063d249e6c62cf7e8cd6757e7860630 > > Diff: https://reviews.apache.org/r/52941/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >