> On Oct. 18, 2016, 11:15 p.m., Vinod Kone wrote: > > src/tests/slave_recovery_tests.cpp, line 3067 > > <https://reviews.apache.org/r/52723/diff/5/?file=1534836#file1534836line3067> > > > > Curious why you didn't write a new test for partition aware framework > > like you did above?
I was trying to strike a balance between good test coverage but not duplicating every existing test that uses `TASK_LOST`; in this case I thought the existing tests were good enough we didn't need a copy, but I'm happy to make a copy if you'd like. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52723/#review153209 ----------------------------------------------------------- On Oct. 13, 2016, 3:10 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52723/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 3:10 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6332 > https://issues.apache.org/jira/browse/MESOS-6332 > > > Repository: mesos > > > Description > ------- > > If a framework attempts to launch a task but the launch message is > dropped after it reaches the master but before it reaches the slave, the > failed launch will be detected during master <-> agent reconciliation > when the agent re-registers. Previously, the agent would generate a > TASK_LOST status update for such dropped tasks; now it will generate > TASK_DROPPED if the framework is partition-aware. > > Note that we'll only send TASK_DROPPED if the agent is running a > sufficiently recent version of Mesos (>= 1.1.0). That means that in a > mixed cluster where the master has been upgraded to Mesos 1.1 but some > of the agents have not been, a partition-aware framework might still see > TASK_LOST in this situation. > > > Diffs > ----- > > src/messages/messages.proto 7d65be1418864333d0c4213e2e0df0374f9ec115 > src/slave/slave.cpp 6bd9b49c3bbdb973a0d03552ae8fe55b33371083 > src/tests/master_slave_reconciliation_tests.cpp > 2983c1b074c2d4179e95e619083f5dd4e9ac6730 > src/tests/slave_recovery_tests.cpp 703948f7a6861a4401ee45ce9cae2644106083f3 > > Diff: https://reviews.apache.org/r/52723/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
