-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52746/
-----------------------------------------------------------
(Updated Oct. 19, 2016, 1:39 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Tweak comments, per review.
Bugs: MESOS-6332
https://issues.apache.org/jira/browse/MESOS-6332
Repository: mesos
Description
-------
If the agent cannot launch a task due to a variety of possible error
conditions, we now send TASK_DROPPED to partition-aware frameworks
rather than TASK_LOST.
Diffs (updated)
-----
src/slave/slave.cpp 6bd9b49c3bbdb973a0d03552ae8fe55b33371083
Diff: https://reviews.apache.org/r/52746/diff/
Testing
-------
`make check`.
Note that none of these code paths appear to have unit tests, so I couldn't
update the unit tests to ensure that `TASK_DROPPED` is sent appropriately. We
should add unit tests for at least some of these situations, if feasible -- but
I'll defer that for now.
Thanks,
Neil Conway
