----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53053/#review153399 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 342) <https://reviews.apache.org/r/53053/#comment222702> Is it possible to move this code to `stout`? Something on the lines of of os::overlayfs::wh? The code is pretty cumbersome and breaks the usual idioms followed in Mesos. More importantly, as far as I understand, we will need the same code for OCI images as well since it follows the AUFS whiteout format as well? src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 343) <https://reviews.apache.org/r/53053/#comment222691> Shouldn't we be putting this code under `#ifdef __linux__`, given that it won't compile for windows? Or more importantly add a `stout` version for posix ? FTS is not available for solaris as well I think? Unless `store.cpp` is intended to compile specifically for linux since `overlayfs` itself is very specific to linux? In which case this comment is very confusing. src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 359) <https://reviews.apache.org/r/53053/#comment222692> There is an assumption that docker images follow the aufs whiteout standard. Probably add a comment and give a citation to the whiteout format followed by docker. In case docker changes tommorow developers would atleast understand the reasoning for this code. src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 368) <https://reviews.apache.org/r/53053/#comment222693> s/\"trusted.overlay.opaque\"/'trusted.overlay.opaque' src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 380) <https://reviews.apache.org/r/53053/#comment222703> break this up? Failure( "Failed to .... - Avinash sridharan On Oct. 20, 2016, 1:53 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53053/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 1:53 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6360 > https://issues.apache.org/jira/browse/MESOS-6360 > > > Repository: mesos > > > Description > ------- > > Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > e192f86a1848b373f3aa73d29688a96375cac313 > > Diff: https://reviews.apache.org/r/53053/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
