----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53061/#review153435 -----------------------------------------------------------
include/mesos/mesos.proto (line 2099) <https://reviews.apache.org/r/53061/#comment222740> s/no limit/unlimited/ include/mesos/v1/mesos.proto (line 2098) <https://reviews.apache.org/r/53061/#comment222741> Ditto. src/common/parse.hpp (line 179) <https://reviews.apache.org/r/53061/#comment222742> please add to `src/v1/parse.hpp` as well src/common/type_utils.cpp (line 513) <https://reviews.apache.org/r/53061/#comment222743> 2 lines apart src/posix/rlimit.hpp (line 25) <https://reviews.apache.org/r/53061/#comment222752> Windows does not use autotool. So you don't have to do this. We just need to make sure all callsites are wrapped with ifndef WINDOWS. src/posix/rlimit.hpp (line 28) <https://reviews.apache.org/r/53061/#comment222744> Let's put under mesos::internal::rlimits namespace src/posix/rlimit.cpp (line 40) <https://reviews.apache.org/r/53061/#comment222754> not supported src/posix/rlimit.cpp (lines 43 - 45) <https://reviews.apache.org/r/53061/#comment222755> I'll put this to the end. src/posix/rlimit.cpp (line 67) <https://reviews.apache.org/r/53061/#comment222753> Looks like STACK is in posix: http://pubs.opengroup.org/onlinepubs/009695399/functions/getrlimit.html src/posix/rlimit.cpp (lines 130 - 134) <https://reviews.apache.org/r/53061/#comment222756> Why do you need to call `getrlimit` here? src/posix/rlimit.cpp (lines 135 - 136) <https://reviews.apache.org/r/53061/#comment222757> We need to use RLIM_INFINITY if both soft and hard are not et. - Jie Yu On Oct. 20, 2016, 5:01 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53061/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 5:01 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6426 > https://issues.apache.org/jira/browse/MESOS-6426 > > > Repository: mesos > > > Description > ------- > > This commit adds high-level functions to set POSIX resource limits and > associated protobuf definitions. > > This is intended to be used by the containerizer in later changes. > > > Diffs > ----- > > include/mesos/mesos.proto 9a268dd0aa2f5ee245ad26bf40ab9b12fe861d2f > include/mesos/type_utils.hpp 88c7bcf7e8c3053e6e8bb78c67bf93b8276ac053 > include/mesos/v1/mesos.proto 855377f56e1693e11b3c0c0cb61a2c3013a66f54 > src/Makefile.am 05fe8fa3e3409b35ba66d7e7238e988fb0fab07d > src/common/parse.hpp ee26717ed54445f57fa3a11c74ece8fe0861bd40 > src/common/type_utils.cpp e249fae458d0fc1d32ea4e8b4a26d1a2d75826f1 > src/posix/rlimit.hpp PRE-CREATION > src/posix/rlimit.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/53061/diff/ > > > Testing > ------- > > * make check (OS X, clang-trunk w/o optimizations) > * tested on a number of Linux setups in internal CI > > > Thanks, > > Benjamin Bannier > >
