----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52840/#review153494 -----------------------------------------------------------
Patch looks great! Reviews applied: [52840] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 20, 2016, 9:31 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52840/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 9:31 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > Silenced a GMock warning in ROOT_DOCKER_DockerInspectDiscard. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 6d26797abf6d2b5e42b9e7743789e1edc62c9c1a > > Diff: https://reviews.apache.org/r/52840/diff/ > > > Testing > ------- > > Without this patch, `"sudo ./src/mesos-tests > --gtest_filter="DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard"` > consistently results in: > > ``` > [ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard > > GMOCK WARNING: > Uninteresting mock function call - returning directly. > Function call: executorLost(0x7ffe1aad15e0, @0x7f2018000b00 e1, > @0x7f2018000c30 0aec7dbf-3ce3-4d3a-a086-a95bd1e8dada-S0, -1) > Stack trace: > [ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (624 ms) > ``` > > With this patch, running the test 100 times in a loop does not produce a > warning. > > > Thanks, > > Neil Conway > >
