> On Oct. 20, 2016, 1:50 p.m., Jie Yu wrote: > > src/tests/containerizer/cgroups_tests.cpp, line 412 > > <https://reviews.apache.org/r/51031/diff/14/?file=1541970#file1541970line412> > > > > Who remove the cgroup created above? > > Jiang Yan Xu wrote: > Hmm, the intention is to have them destroyed in teardown but I guess > these cgroups don't start with `TEST_CGROUPS_ROOT`. I'll add back these > removal lines and we can think about how to do auto-cleanup better. > > haosdent huang wrote: > Because > > ``` > const static std::string TEST_CGROUPS_ROOT = "mesos_test"; > ``` > > these cgroups would be clear during the teardown as well. Let me to make > this more clear.
Oh I see, but this feels totally non-obvious: The test itself doesn't use the variable `TEST_CGROUPS_ROOT` but it expects TearDown to use it. A couple of other tests do this as well. Maybe we'll just do the old way of removing these cgroups in the test itself and do another sweep to do auto-cleanup better? - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/#review153455 ----------------------------------------------------------- On Oct. 20, 2016, 6:15 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51031/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 6:15 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, Zhengju Sha, and > Jiang Yan Xu. > > > Bugs: MESOS-6035 > https://issues.apache.org/jira/browse/MESOS-6035 > > > Repository: mesos > > > Description > ------- > > In most cases, we just want to get the children cgroups instead of > retrieve descendant cgroups recursively. We added an argument to > `cgroups::get` to indicate whether to retrieve cgroups recursively and > made non-recursive retrieve the default behaviour. This patch fixed > some incorrect `TEST_CGROUPS_ROOT` checks as well. > > > Diffs > ----- > > src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d > src/linux/cgroups.cpp 630e2ec2d0eac2bb35488d0416883df1601224c8 > src/slave/containerizer/fetcher.cpp > ea8eaa6371fc322c240e17b4bb9ba417c45ceaca > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 2f6723c64261fb3295626d6479fe844fb23b0650 > src/slave/containerizer/mesos/linux_launcher.cpp > 0305d14c1f791c93edcd3b32786b483b15f40a2d > src/tests/containerizer/cgroups_tests.cpp > 0afaec6ae948cabf1472bf01103210d8f9809cb1 > src/tests/containerizer/mesos_containerizer_tests.cpp > 4df537747d84daa68c29e2d05b22fa386a4a16db > src/tests/mesos.cpp 2aae160fb941ab3672a5665ae27f517ff40600e2 > > Diff: https://reviews.apache.org/r/51031/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
