----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52975/#review153587 -----------------------------------------------------------
Can you introduce a new file called resources_utils.hpp / cpp? - Benjamin Mahler On Oct. 18, 2016, 5:27 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52975/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 5:27 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Factored out the create port range logic to test utils. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 2e979d784b8e6cdacebac78a67498b5f4d023540 > src/tests/sorter_tests.cpp 1f17c011898836ea9159661dde7d544cb0d8ea83 > src/tests/utils.hpp 140ebaaae43b03568ec49891635f0660cdfb4c85 > src/tests/utils.cpp fc004a9c567898ffbc38a42cc2340dd57347a829 > > Diff: https://reviews.apache.org/r/52975/diff/ > > > Testing > ------- > > make > make check > > ``` > ./bin/mesos-tests.sh --benchmark > --gtest_filter="*HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/0" > ./bin/mesos-tests.sh --benchmark > --gtest_filter="*Sorter_BENCHMARK_Test.FullSort/*" > ``` > > > Thanks, > > Guangya Liu > >
