----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53033/#review153601 -----------------------------------------------------------
src/slave/slave.cpp (line 1161) <https://reviews.apache.org/r/53033/#comment223007> do you want to change this too? src/slave/slave.cpp (lines 1217 - 1218) <https://reviews.apache.org/r/53033/#comment223008> LOG(INFO) << "Agent " << slaveId << " re-registered with master" << master.get(); src/slave/slave.cpp (lines 1235 - 1237) <https://reviews.apache.org/r/53033/#comment223009> LOG(INFO) << "Agent " << slaveId << " ignorning re-registration message from master" << master.get() << " because it is already registered"; - Vinod Kone On Oct. 19, 2016, 8:48 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53033/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 8:48 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > We should show the agent ID that we successfully re-registered with: > both for consistency with the log message upon initial registration, and > because this is useful information when debugging agent behavior. > > > Diffs > ----- > > src/slave/slave.cpp 6bd9b49c3bbdb973a0d03552ae8fe55b33371083 > > Diff: https://reviews.apache.org/r/53033/diff/ > > > Testing > ------- > > Visual inspection of revised log output. > > > Thanks, > > Neil Conway > >
