----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52769/#review153625 -----------------------------------------------------------
Fix it, then Ship it! src/tests/resources_tests.cpp (line 2736) <https://reviews.apache.org/r/52769/#comment223030> How about ScalarArithmeticParameter since this is only used for scalar arithmetic? - Benjamin Mahler On Oct. 18, 2016, 6:50 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52769/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 6:50 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5898 > https://issues.apache.org/jira/browse/MESOS-5898 > > > Repository: mesos > > > Description > ------- > > As we are going to introduce some other paramters for resources > benchmark test, such as `ContainsParameter`, `ValidateParameter` > etc, so it is better to do some rename for current resources > benchmark test as following: > 1) s/Parameter/ScalarParameter > 2) s/Resources_BENCHMARK_Test/Resources_Scalar_Arithmetic_BENCHMARK_Test > > I also add a `TODO` for ports resources by mentioning that this > will be moved to a separate class. > > > Diffs > ----- > > src/tests/resources_tests.cpp 6a12783c26f359dda835b4866b299a8fcfb3f972 > > Diff: https://reviews.apache.org/r/52769/diff/ > > > Testing > ------- > > make > make check > > ``` > ./bin/mesos-tests.sh --benchmark > --gtest_filter="*Resources_Scalar_Arithmetic_BENCHMARK_Test.Arithmetic/*" > [==========] Running 4 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 4 tests from > ResourcesScalarArithmeticOperators/Resources_Scalar_Arithmetic_BENCHMARK_Test > [ RUN ] > ResourcesScalarArithmeticOperators/Resources_Scalar_Arithmetic_BENCHMARK_Test.Arithmetic/0 > Took 55168us to perform 50000 'total += r' operations on cpus(*):1; > gpus(*):1; mem(*):128; disk(*):256 > Took 62085us to perform 50000 'total -= r' operations on cpus(*):1; > gpus(*):1; mem(*):128; disk(*):256 > Took 261178us to perform 50000 'total = total + r' operations on cpus(*):1; > gpus(*):1; mem(*):128; disk(*):256 > Took 268195us to perform 50000 'total = total - r' operations on cpus(*):1; > gpus(*):1; mem(*):128; disk(*):256 > [ OK ] > ResourcesScalarArithmeticOperators/Resources_Scalar_Arithmetic_BENCHMARK_Test.Arithmetic/0 > (647 ms) > [ RUN ] > ResourcesScalarArithmeticOperators/Resources_Scalar_Arithmetic_BENCHMARK_Test.Arithmetic/1 > Took 4.669803secs to perform 10 'total += r' operations on cpus(0, > principal_0, {key_0: value_0}):1; gpus(... > Took 4.823108secs to perform 10 'total -= r' operations on cpus(0, > principal_0, {key_0: value_0}):1; gpus(... > Took 4.951598secs to perform 10 'total = total + r' operations on cpus(0, > principal_0, {key_0: value_0}):1; gpus(... > Took 5.214348secs to perform 10 'total = total - r' operations on cpus(0, > principal_0, {key_0: value_0}):1; gpus(... > [ OK ] > ResourcesScalarArithmeticOperators/Resources_Scalar_Arithmetic_BENCHMARK_Test.Arithmetic/1 > (19711 ms) > [ RUN ] > ResourcesScalarArithmeticOperators/Resources_Scalar_Arithmetic_BENCHMARK_Test.Arithmetic/2 > Took 521273us to perform 1000 'total += r' operations on ports(*):[1-2, 4-5, > 7-8, 10-11, 13-14, 16-17, 1... > Took 2581us to perform 1000 'total -= r' operations on ports(*):[1-2, 4-5, > 7-8, 10-11, 13-14, 16-17, 1... > Took 591917us to perform 1000 'total = total + r' operations on > ports(*):[1-2, 4-5, 7-8, 10-11, 13-14, 16-17, 1... > Took 2698us to perform 1000 'total = total - r' operations on ports(*):[1-2, > 4-5, 7-8, 10-11, 13-14, 16-17, 1... > [ OK ] > ResourcesScalarArithmeticOperators/Resources_Scalar_Arithmetic_BENCHMARK_Test.Arithmetic/2 > (1120 ms) > [ RUN ] > ResourcesScalarArithmeticOperators/Resources_Scalar_Arithmetic_BENCHMARK_Test.Arithmetic/3 > Took 42435us to perform 50000 'total += r' operations on cpus(*):1; > mem(*):128; disk(test)[persistentId:... > Took 47280us to perform 50000 'total -= r' operations on cpus(*):1; > mem(*):128; disk(test)[persistentId:... > Took 304882us to perform 50000 'total = total + r' operations on cpus(*):1; > mem(*):128; disk(test)[persistentId:... > Took 308836us to perform 50000 'total = total - r' operations on cpus(*):1; > mem(*):128; disk(test)[persistentId:... > [ OK ] > ResourcesScalarArithmeticOperators/Resources_Scalar_Arithmetic_BENCHMARK_Test.Arithmetic/3 > (703 ms) > [----------] 4 tests from > ResourcesScalarArithmeticOperators/Resources_Scalar_Arithmetic_BENCHMARK_Test > (22181 ms total) > > [----------] Global test environment tear-down > [==========] 4 tests from 1 test case ran. (22196 ms total) > [ PASSED ] 4 tests. > ``` > > > Thanks, > > Guangya Liu > >
