> On Oct. 21, 2016, 9:37 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 821 > > <https://reviews.apache.org/r/53067/diff/1/?file=1542375#file1542375line821> > > > > s/agent ID/agent/
If we say "Terminating agent 123; agent will register and obtain a new agent ID the next time it is started", this doesn't quite make sense grammatically: when we say "terminating agent 123", "agent" refers to the lifetime of a particular _agent ID_; when we say "agent will register ... the next time it is started", "agents" refers to a particular _mesos-agent Unix process_. So I was trying to make this distinction clear by talking about "terminating an agent ID", which I admit is a bit clunky. What do you think? - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53067/#review153602 ----------------------------------------------------------- On Oct. 20, 2016, 4:53 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53067/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 4:53 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > When an agent ID is terminated (e.g., due to "--recover=cleanup"), it > seems important to notify the operator that the agent will be assigned a > new agent ID when it is next started. > > > Diffs > ----- > > src/slave/slave.cpp 6bd9b49c3bbdb973a0d03552ae8fe55b33371083 > > Diff: https://reviews.apache.org/r/53067/diff/ > > > Testing > ------- > > Visual inspection of log output. > > > Thanks, > > Neil Conway > >
