----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53112/#review153753 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Oct. 24, 2016, 10:35 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53112/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 10:35 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > After launching a task, we need to wait for the slave to receive the > scheduler's ack of the initial TASK_RUNNING status update. If not, the > status update might be re-delivered after we restart the master, which > would break some test case expectations. > > Also cleanup some test code along the way. > > > Diffs > ----- > > src/tests/master_tests.cpp 9963a0cb360f1e72c17c5a6e75bb88b17cdee467 > > Diff: https://reviews.apache.org/r/53112/diff/ > > > Testing > ------- > > `make check` > `mesos-tests --gtest_filter=MasterTest.UnreachableTaskAfterFailover > --gtest_repeat=1000 --gtest_break_on_failure` > > Note that I couldn't repro the original test flakiness on my local machine, > but from the log (https://builds.apache.org/job/mesos-reviewbot/15778), this > seems to be the problem. > > > Thanks, > > Neil Conway > >
