----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/#review153967 -----------------------------------------------------------
Patch looks great! Reviews applied: [45991, 45995, 45996, 45999, 46094, 46146, 40266, 51049, 50621, 40410, 40411, 40413, 40268, 40512, 50736, 51065, 52938, 50737, 50969, 50857] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 26, 2016, 10:40 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50857/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2016, 10:40 p.m.) > > > Review request for mesos, Joseph Wu and Vinod Kone. > > > Bugs: MESOS-3753 > https://issues.apache.org/jira/browse/MESOS-3753 > > > Repository: mesos > > > Description > ------- > > This patch modifies the test `SchedulerTest.Teardown` to > be parametrized by both `ContentType` and SSL configuration, > and renames it to `SchedulerSSLTest.RunTaskAndTeardown`. > This allows the test to verify the scheduler's behavior with > SSL both enabled and disabled. > > > Diffs > ----- > > src/tests/scheduler_tests.cpp 6e876a7184204407c8ba4cb2300e095c29a6c8fb > > Diff: https://reviews.apache.org/r/50857/diff/ > > > Testing > ------- > > The test was run in repetition as follows: > > `GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 > GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown*" > bin/mesos-tests.sh` > > > Thanks, > > Greg Mann > >
