----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/#review153993 -----------------------------------------------------------
src/tests/health_check_tests.cpp (line 1463) <https://reviews.apache.org/r/52251/#comment223495> s/healthy task/healthy non-contained task src/tests/health_check_tests.cpp (lines 1463 - 1464) <https://reviews.apache.org/r/52251/#comment223512> Please say something like: // NOTE: This test is almost identical to HealthyTaskViaHTTP with the difference being TCP health check. src/tests/health_check_tests.cpp (line 1472) <https://reviews.apache.org/r/52251/#comment223496> kill this line src/tests/health_check_tests.cpp (line 1492) <https://reviews.apache.org/r/52251/#comment223497> const src/tests/health_check_tests.cpp (line 1496) <https://reviews.apache.org/r/52251/#comment223498> const src/tests/health_check_tests.cpp (line 1516) <https://reviews.apache.org/r/52251/#comment223499> statusHealthy src/tests/health_check_tests.cpp (lines 1520 - 1521) <https://reviews.apache.org/r/52251/#comment223500> `WillRepeatedly` src/tests/health_check_tests.cpp (lines 1621 - 1622) <https://reviews.apache.org/r/52251/#comment223501> Please add // To emulate a task responsive to TCP health checks, starts Netcat in the docker "alpine" image. // // NOTE: This test is almost identical to ROOT_INTERNET_CURL_HealthyTaskViaHTTPWithContainerImage with the difference being TCP health check. src/tests/health_check_tests.cpp (line 1635) <https://reviews.apache.org/r/52251/#comment223502> kill this line. src/tests/health_check_tests.cpp (line 1655) <https://reviews.apache.org/r/52251/#comment223503> const src/tests/health_check_tests.cpp (line 1658) <https://reviews.apache.org/r/52251/#comment223504> const src/tests/health_check_tests.cpp (line 1666) <https://reviews.apache.org/r/52251/#comment223505> please be consistent and use "alpine" src/tests/health_check_tests.cpp (line 1684) <https://reviews.apache.org/r/52251/#comment223506> statusHealthy src/tests/health_check_tests.cpp (lines 1688 - 1689) <https://reviews.apache.org/r/52251/#comment223507> WillRepeatedly... src/tests/health_check_tests.cpp (lines 1832 - 1833) <https://reviews.apache.org/r/52251/#comment223513> // NOTE: This test is almost identical to ROOT_DOCKER_DockerHealthyTaskViaHTTP with the difference being TCP health check. src/tests/health_check_tests.cpp (line 1879) <https://reviews.apache.org/r/52251/#comment223508> const src/tests/health_check_tests.cpp (line 1882) <https://reviews.apache.org/r/52251/#comment223509> const src/tests/health_check_tests.cpp (lines 1921 - 1922) <https://reviews.apache.org/r/52251/#comment223510> WillRepeatedly... - Alexander Rukletsov On Oct. 21, 2016, 11:12 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52251/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2016, 11:12 a.m.) > > > Review request for mesos, Alexander Rukletsov and Gastón Kleiman. > > > Bugs: MESOS-6279 > https://issues.apache.org/jira/browse/MESOS-6279 > > > Repository: mesos > > > Description > ------- > > Added test cases for TCP health check. > > > Diffs > ----- > > src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522 > > Diff: https://reviews.apache.org/r/52251/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
