----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53275/#review154190 -----------------------------------------------------------
Fix it, then Ship it! src/tests/master_tests.cpp (line 2941) <https://reviews.apache.org/r/53275/#comment223672> s/This to/This is used to src/tests/master_tests.cpp (line 2945) <https://reviews.apache.org/r/53275/#comment223677> Kill this. It's self explanatory. src/tests/master_tests.cpp (line 2984) <https://reviews.apache.org/r/53275/#comment223673> Remove this. I thought we stopped doing `Times(1)` since it's the default? src/tests/master_tests.cpp (line 3020) <https://reviews.apache.org/r/53275/#comment223674> Ditto as above. src/tests/master_tests.cpp (lines 3048 - 3050) <https://reviews.apache.org/r/53275/#comment223675> Kill this and also the `pause()` on L3041. `StartMaster()` should already be doing a `settle()` ensuring `_recover()` is executed. src/tests/master_tests.cpp (lines 3058 - 3083) <https://reviews.apache.org/r/53275/#comment223678> You might want to scope this for readability: ```cpp // Ensure that there are 2 orphan tasks and 1 unregistered framework // in "/state" endpoint. { Future<Response> ... = ...; } // Ensure that there is 1 unregistered framework in "/frameworks" endpoint. { Future<Response> ... = ...; } ``` src/tests/master_tests.cpp (line 3111) <https://reviews.apache.org/r/53275/#comment223676> Kill this. - Anand Mazumdar On Oct. 28, 2016, 10:30 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53275/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2016, 10:30 p.m.) > > > Review request for mesos, Anand Mazumdar and Jiang Yan Xu. > > > Bugs: MESOS-6501 > https://issues.apache.org/jira/browse/MESOS-6501 > > > Repository: mesos > > > Description > ------- > > Added a test for duplicate frameworks in "unregistered_frameworks". > > > Diffs > ----- > > src/tests/master_tests.cpp 968192c414c9a5db9b2dd038bc83677230bf467c > > Diff: https://reviews.apache.org/r/53275/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
