----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/#review154228 -----------------------------------------------------------
src/docker/executor.hpp (lines 36 - 39) <https://reviews.apache.org/r/52879/#comment223719> Some typo in this comment: ``` // TODO(gkleiman): This class should inherit from `mesos::internal::v1:executor::Flags` to be consistent with the other executors, but the extra fields in it don't jive well with the params generation code in `DockerContainerizer`. ``` src/docker/executor.hpp (lines 95 - 102) <https://reviews.apache.org/r/52879/#comment223721> Should we put `Duration executor_shutdown_grace_period;` after `std::string launcher_dir;`? ``` std::string launcher_dir; Duration executor_shutdown_grace_period; ``` - haosdent huang On Oct. 28, 2016, 11:43 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52879/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2016, 11:43 a.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, Jie Yu, and Jiang Yan Xu. > > > Bugs: MESOS-6494 > https://issues.apache.org/jira/browse/MESOS-6494 > > > Repository: mesos > > > Description > ------- > > Updated the executors so that they use only `stout::flags` to load > config options. > > They used to use a mix of `stout::flags` and `os::getenv`. > > > Diffs > ----- > > src/CMakeLists.txt 639f8678ba23c4d9a2ea0bf84fbc3d6fc9286ef3 > src/Makefile.am 769e998d80fde17bcb1ee6c5091ce13a1ad16137 > src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 > src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 > src/exec/exec.cpp 1dc20390907253a466b7272b7f8b33ea14afb236 > src/exec/flags.hpp PRE-CREATION > src/exec/flags.cpp PRE-CREATION > src/executor/executor.cpp 1d47b52d89eedee59d160badd6313d34e3bdb6d2 > src/executor/flags.hpp PRE-CREATION > src/executor/flags.cpp PRE-CREATION > src/launcher/default_executor.cpp af4a97f7de5f2157aa65fdab742455b0683c40a4 > src/launcher/executor.hpp 217680d99d6e8c31130d7dc714f8cd730f360852 > src/launcher/executor.cpp 0544121e679db503fe4eaf23a24e315eb188a520 > src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 > src/tests/containerizer.cpp 69b93c70dc883e1edff3e6c2d7c8da9ef05e42f8 > > Diff: https://reviews.apache.org/r/52879/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Gastón Kleiman > >
