Re: Review Request 53293: Show framework's role and principal in WebUI.

[Mesos ReviewBot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53293/#review154237
-----------------------------------------------------------



Patch looks great!

Reviews applied: [53293]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 30, 2016, 8:49 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53293/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2016, 8:49 a.m.)
> 
> 
> Review request for mesos, Deshna Jain and Vinod Kone.
> 
> 
> Bugs: MESOS-5444
>     https://issues.apache.org/jira/browse/MESOS-5444
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mesos show framework's role and principal in WebUI since
> https://reviews.apache.org/r/47702/. Due to the incomplete information
> in the state endpoint of agents, it didn't show framework's role and
> principal in `agent.html` and `agent_framework.html`. This is a
> follow-up patch to fix that problem.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp a32aca437cffd52bc2bcde859eedddca2038e3f1 
>   src/webui/master/static/agent.html 3d15d55dddd0c15b8e882c2356cab2e1a0ad6291 
>   src/webui/master/static/agent_framework.html 
> 806ab06063dcf62cd6d1d7913840ed83141bd1eb 
> 
> Diff: https://reviews.apache.org/r/53293/diff/
> 
> 
> Testing
> -------
> 
> ---
> 
> 
> ![principal_1](https://issues.apache.org/jira/secure/attachment/12836004/principal_1.png)
> ![principal_2](https://issues.apache.org/jira/secure/attachment/12836006/principal_2.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>