----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53305/ -----------------------------------------------------------
(Updated Oct. 31, 2016, 5:18 p.m.) Review request for mesos. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description ------- Add new param user to logrotate's prepare function. Diffs ----- include/mesos/slave/container_logger.hpp 939974736f9eb744c83036e074718d2a1eba8b0a src/slave/container_loggers/lib_logrotate.hpp 28fdf3bdcc66d473521b377f66ab0b48f6900f58 src/slave/container_loggers/lib_logrotate.cpp 53698d339f0f4d2dc916b53239ca0c36bbebcd42 src/slave/container_loggers/logrotate.hpp d1db69236f5a9b1dbb3113ad02218a512afdb46b src/slave/container_loggers/sandbox.hpp e0aeb32a9ec83af049af8a10010b819c1d8b25d8 src/slave/container_loggers/sandbox.cpp cc263ebef7e0c3e778fabafa49faa6dd315adc45 src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 src/slave/containerizer/mesos/containerizer.cpp 67cc595278f124cdf518d2f4fcfb257439f067e2 Diff: https://reviews.apache.org/r/53305/diff/ Testing ------- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan