----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53309/#review154336 -----------------------------------------------------------
Patch looks great! Reviews applied: [53266, 53303, 53309] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 31, 2016, 4:11 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53309/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 4:11 p.m.) > > > Review request for mesos, Till Toenshoff, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-6455 > https://issues.apache.org/jira/browse/MESOS-6455 > > > Repository: mesos > > > Description > ------- > > This test is parameterized, making it run with both the Docker and the > Mesos containerizers. > > The test name doesn't contain `DOCKER_`, so the test instantiation that > uses the Docker containerizer will run and fail if Docker is not > available. > > Because the test name starts with `ROOT_`, it only runs if root tests > are not filtered, but the Mesos containerizer doesn't need to run as > root. > > I extracted a fixture method from the test, so that I could split > `ROOT_TaskUsesExecutor` into `TaskUsesExecutor` and > `ROOT_DOCKER_TaskUsesExecutor`. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 70779e8d94fbb6e664cad4ddbfeb19e560176cfe > > Diff: https://reviews.apache.org/r/53309/diff/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter=DefaultExecutorTest.* > --docker=/tmp/foo` > `sudo bin/mesos-tests.sh --gtest_filter=DefaultExecutorTest.*` > > > Thanks, > > Gastón Kleiman > >
