----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52997/ -----------------------------------------------------------
(Updated Nov. 1, 2016, 12:22 a.m.) Review request for mesos, Joris Van Remoortere and Michael Park. Bugs: MESOS-6412 https://issues.apache.org/jira/browse/MESOS-6412 Repository: mesos Description (updated) ------- Rather than returning a fixed generic error when connect(2) fails, report the actual socket error as well as the address we were trying to connect to. Diffs (updated) ----- 3rdparty/libprocess/src/poll_socket.cpp d9ab3fbbf385c39c0e43ee92ff06609ae8d47e2d Diff: https://reviews.apache.org/r/52997/diff/ Testing ------- `make check` on a host whose hostname doesn't match its IP address. ``` [jpeach@jpeach libprocess]$ ./libprocess-tests --gtest_filter=HTTPTest.Endpoints Note: Google Test filter = HTTPTest.Endpoints [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from HTTPTest [ RUN ] HTTPTest.Endpoints ../../../3rdparty/libprocess/src/tests/http_tests.cpp:141: Failure (socket.connect(http.process->self().address)).failure(): Failed to connect to 17.203.52.49:39241: Connection refused [ FAILED ] HTTPTest.Endpoints (4 ms) [----------] 1 test from HTTPTest (4 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (5 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] HTTPTest.Endpoints 1 FAILED TEST ``` Thanks, James Peach