> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 691 > > <https://reviews.apache.org/r/50599/diff/15/?file=1543834#file1543834line691> > > > > This is OK since we do this the same in other functions for this class, > > but we should really wrap pointers like this in Owned<> or Shared<> > > depending on their semantics.
I think that you did not resolve this, please keep this open. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review153839 ----------------------------------------------------------- On 十一月 1, 2016, 6:11 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50599/ > ----------------------------------------------------------- > > (Updated 十一月 1, 2016, 6:11 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Assigned Nvidia GPU devices to docker container based on > GPUs allocated by Nvidia GPU allocator. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d > src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 > > Diff: https://reviews.apache.org/r/50599/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
