----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53137/#review154394 -----------------------------------------------------------
Fix it, then Ship it! Thanks for this series, really looking forward to it. Do you also have a patch for stout's `configure.ac`? It has similar issues. configure.ac (line 208) <https://reviews.apache.org/r/53137/#comment223912> Since you nicely fixed this in the patch for libprocess' `configure.ac` please `s/google/Google/` here as well. - Benjamin Bannier On Oct. 31, 2016, 11:27 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53137/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 11:27 p.m.) > > > Review request for mesos and Kapil Arya. > > > Bugs: MESOS-2537 > https://issues.apache.org/jira/browse/MESOS-2537 > > > Repository: mesos > > > Description > ------- > > Fix all the AC_ARG_ENABLED options to correctly handle --enable-foo > and --disable-foo variants. Update all the invocations to have a > consistent calling convention. > > > Diffs > ----- > > configure.ac c8d48be41d526c45ee00b404d0ad2b67ea11587f > > Diff: https://reviews.apache.org/r/53137/diff/ > > > Testing > ------- > > Make check on OS X and Fedora 24. > > > Thanks, > > James Peach > >
