> On Oct. 31, 2016, 3:47 p.m., Jiang Yan Xu wrote: > > src/webui/master/static/home.html, line 26 > > <https://reviews.apache.org/r/53285/diff/2/?file=1548868#file1548868line26> > > > > Since `hostname` is deprecated, use `address.hostname`? If that's not > > available, fall back to the current behavior: ip:port? > > haosdent huang wrote: > Good patch! It is my bad use it in > https://github.com/apache/mesos/commit/34eb567c4e0ed605eeed02a20213f28d51a4e305 > Do you think is it OK to update there to use `info.address`. It would looks > like: > > ``` > static void json(JSON::ObjectWriter* writer, const MasterInfo& info) > { > writer->field("id", info.id()); > writer->field("pid", info.pid()); > writer->field("port", info.address().port()); > writer->field("hostname", info.address().hostname()); > } > ```
Oh OK I see. Sure if you do that in a separate review it would be more in line with the suggested usage. And it looks like the `hostname` field in the json object should always be there so we don't need a fall back behavior. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53285/#review154334 ----------------------------------------------------------- On Oct. 29, 2016, 8:05 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53285/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2016, 8:05 a.m.) > > > Review request for mesos, Vinod Kone and Jiang Yan Xu. > > > Bugs: MESOS-6448 > https://issues.apache.org/jira/browse/MESOS-6448 > > > Repository: mesos > > > Description > ------- > > Show the leader information in WebUI. > > > Diffs > ----- > > src/webui/master/static/home.html 07f862f69802bef8fda2d0a94e33c3b463ddcd4c > > Diff: https://reviews.apache.org/r/53285/diff/ > > > Testing > ------- > >  >  > > > Thanks, > > haosdent huang > >
