-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53378/
-----------------------------------------------------------
(Updated Nov. 2, 2016, 3:47 p.m.)
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-6457
https://issues.apache.org/jira/browse/MESOS-6457
Repository: mesos
Description (updated)
-------
The command and Docker executors would send health updates even after
having transitioned a task to `TASK_KILLING`, leading to `TASK_KILLING
-> TASK_RUNNING` transitions.
This patch makes those executors skip health updates after starting to
kill a task.
The test for the Docker executor goes in a separate patch, because it
uses a TCP health check that aren't available in Mesos 0.28.x.
Diffs (updated)
-----
CHANGELOG ed78657492eb3a708cdeaf9cf40d0a70270a5699
src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8
src/launcher/executor.cpp 0544121e679db503fe4eaf23a24e315eb188a520
src/tests/command_executor_tests.cpp 6e47243941626bb5b6224430f9a12ced8a3f5062
Diff: https://reviews.apache.org/r/53378/diff/
Testing (updated)
-------
Added a test ensuring that the command executor doesn't transition tasks from
`TASK_KILLING` to `TASK_RUNNING`. It fails on both OS X and Linux without the
executor changes.
It passes with the executor changes.
The next patch in the chain adds a test for the Docker executor.
Thanks,
Gastón Kleiman
