----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53413/#review154665 -----------------------------------------------------------
Ship it! Confirmed this fixes the FD leak. - Joseph Wu On Nov. 2, 2016, 4:48 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53413/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2016, 4:48 p.m.) > > > Review request for mesos, Joseph Wu and Jiang Yan Xu. > > > Bugs: MESOS-5218 > https://issues.apache.org/jira/browse/MESOS-5218 > > > Repository: mesos > > > Description > ------- > > Fix FD leak due to exiting early in mesos fetcher. > > > Diffs > ----- > > src/slave/containerizer/fetcher.cpp > ea8eaa6371fc322c240e17b4bb9ba417c45ceaca > > Diff: https://reviews.apache.org/r/53413/diff/ > > > Testing > ------- > > Tests passed. > > > Thanks, > > Anindya Sinha > >