----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53386/#review154681 -----------------------------------------------------------
Ship it! src/jvm/jvm.cpp (line 90) <https://reviews.apache.org/r/53386/#comment224359> This could in principle now remain in its original location, but I agree that having it declared closer to its actual use is more readible. - Benjamin Bannier On Nov. 3, 2016, 12:56 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53386/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 12:56 a.m.) > > > Review request for mesos and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Fixed memory leak in JVM code. > > > Diffs > ----- > > src/jvm/jvm.cpp 62f7857180162c510269b5d10f5add94ab354fa2 > > Diff: https://reviews.apache.org/r/53386/diff/ > > > Testing > ------- > > `make check` > > Verified that observed `clang-tidy` leak warning goes away with this change. > > > Thanks, > > Neil Conway > >
